-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to center children around the new parent when reparenting #84995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitlytic
force-pushed
the
reparent-center
branch
from
November 17, 2023 02:38
6e24588
to
2843884
Compare
KoBeWi
reviewed
Nov 20, 2023
KoBeWi
reviewed
Nov 20, 2023
KoBeWi
reviewed
Nov 20, 2023
KoBeWi
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks fine.
Though making it an editor setting disabled by default means poor discoverability. Maybe it could be an option in the ⋮
menu.
YuriSizov
changed the title
New parent node can be centered around child nodes
Add an option to center children around the new parent when reparenting
Nov 21, 2023
KoBeWi
reviewed
Nov 25, 2023
KoBeWi
reviewed
Nov 25, 2023
akien-mga
force-pushed
the
reparent-center
branch
from
February 14, 2024 12:46
ed3bf4b
to
f9e0345
Compare
Pushed a rebase to squash the commits. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality of proposal #8449, in the case that others feel this would be a good enhancement.
This enhances the "Reparent to New Node" tool in the Scene view by adding the ability to create a new based around the selected node(s) rather than always adding the new parent node at the origin.
Production edit: Closes godotengine/godot-proposals#8449