Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to center children around the new parent when reparenting #84995

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Bitlytic
Copy link
Contributor

@Bitlytic Bitlytic commented Nov 17, 2023

Adds the functionality of proposal #8449, in the case that others feel this would be a good enhancement.

This enhances the "Reparent to New Node" tool in the Scene view by adding the ability to create a new based around the selected node(s) rather than always adding the new parent node at the origin.

Production edit: Closes godotengine/godot-proposals#8449

@Bitlytic Bitlytic marked this pull request as ready for review November 17, 2023 02:07
@Bitlytic Bitlytic requested review from a team as code owners November 17, 2023 02:07
@Bitlytic Bitlytic marked this pull request as draft November 17, 2023 02:07
@AThousandShips AThousandShips added this to the 4.x milestone Nov 17, 2023
@Bitlytic Bitlytic marked this pull request as ready for review November 20, 2023 00:27
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine.

Though making it an editor setting disabled by default means poor discoverability. Maybe it could be an option in the menu.

@YuriSizov YuriSizov changed the title New parent node can be centered around child nodes Add an option to center children around the new parent when reparenting Nov 21, 2023
editor/scene_tree_dock.cpp Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Pushed a rebase to squash the commits.

@akien-mga akien-mga merged commit d3f64bf into godotengine:master Feb 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New node created from "Reparent to New Node" positioned relative to the child nodes, not the origin
5 participants